source: Klonkt/test/activitypub-as2.test.js@ 0688b5f

main
Last change on this file since 0688b5f was 0688b5f, checked in by roboburr <roboburr@…>, 2 months ago

feat(fediverse): post language → AS2 contentMap

A post can now carry a language; it federates as an AS2 contentMap (a BCP-47-keyed
copy of the content, alongside plain content) so Mastodon's timeline language filter
and translate button work. Editor gets a language picker (defaults to the author's
UI language).

  • src/config/database.js — posts.language column.
  • src/services/ActivityPubService.js — buildNote emits contentMap { <lang>: content } when the post has a valid BCP-47 language.
  • src/routes/posts.js — capture/validate/store language on create/save (default = the author's current language) and pass it to the federation hooks.
  • src/services/Scheduler.js — carry language when a scheduled post goes live.
  • src/views/pages/post-edit.ejs — language <select> (18 common languages).
  • src/services/i18n.js — pedit.f_language + pedit.language_hint (nl/en/de).
  • test/activitypub-as2.test.js — allow contentMap/nameMap/summaryMap; don't treat a language-map's keys as vocab terms; kitchen-sink post now sets a language.
  • test/post-language.test.js — contentMap shape, no-language, invalid-code = ignored.
  • CHANGELOG(.nl/.de).md — "Set a post's language" under Unreleased.

Co-Authored-By: Claude <noreply@…>

  • Property mode set to 100644
File size: 4.8 KB
Line 
1// AS2 / JSON-LD validity guard.
2//
3// Every property key and `type` value our ActivityPub objects emit MUST be either an AS2-core
4// (or security/v1) term OR declared in the federation @context (AP_CONTEXT). A new feature that
5// emits an undeclared term fails this test → declare it in AP_CONTEXT (extensions) or add it to
6// the AS2 allowlist below. This keeps Klonkt's output valid AS2/JSON-LD forever — not just
7// "Mastodon tolerates it". No extra deps; in-memory SQLite. Run: npm test
8import { test } from 'node:test';
9import assert from 'node:assert/strict';
10
11process.env.DATABASE_PATH = ':memory:';
12process.env.PUBLIC_BASE_URL = 'https://test.example';
13
14const dbMod = await import('../src/config/database.js');
15const db = dbMod.default;
16dbMod.initializeDatabase();
17const AP = (await import('../src/services/ActivityPubService.js')).default;
18
19const BASE = 'https://test.example';
20
21// AS2-core + security/v1 vocabulary Klonkt uses (stable — only extend when AS2/security itself
22// adds a term we adopt). JSON-LD keywords included.
23const AS2 = new Set([
24 '@context', '@id', '@type',
25 'id', 'type', 'actor', 'object', 'target', 'to', 'cc',
26 'content', 'name', 'summary', 'url', 'href', 'mediaType',
27 'published', 'updated', 'attributedTo', 'inReplyTo', 'replies',
28 'attachment', 'tag', 'icon', 'image', 'duration',
29 'contentMap', 'nameMap', 'summaryMap', // AS2 @language-map counterparts of content/name/summary
30 'totalItems', 'orderedItems', 'items', 'first', 'last', 'partOf', 'next', 'prev',
31 'preferredUsername', 'inbox', 'outbox', 'followers', 'following', 'endpoints', 'sharedInbox',
32 'publicKey', 'owner', 'publicKeyPem',
33 'Note', 'Person', 'Create', 'Update', 'Delete', 'Tombstone', 'Announce', 'Like', 'Follow',
34 'Accept', 'Reject', 'Undo', 'Add', 'Remove', 'Document', 'Image', 'Audio', 'Video',
35 'Mention', 'Link', 'Collection', 'OrderedCollection', 'OrderedCollectionPage',
36]);
37
38// The extension terms = exactly the keys declared in AP_CONTEXT's term-definition object.
39const ctxTerms = new Set();
40for (const part of AP.AP_CONTEXT) if (part && typeof part === 'object') for (const k of Object.keys(part)) ctxTerms.add(k);
41const allowed = new Set([...AS2, ...ctxTerms]);
42
43// Collect every property key + every `type` string value, recursively.
44function collect(obj, keys = new Set()) {
45 if (Array.isArray(obj)) { for (const x of obj) collect(x, keys); return keys; }
46 if (obj && typeof obj === 'object') {
47 for (const [k, v] of Object.entries(obj)) {
48 keys.add(k);
49 if (k === 'type' && typeof v === 'string') keys.add(v);
50 if (/Map$/.test(k)) continue; // a @language map (contentMap/…): its keys are BCP-47 tags, not vocab terms
51 collect(v, keys);
52 }
53 }
54 return keys;
55}
56function assertValid(obj, label) {
57 const undeclared = [...collect(obj)].filter((k) => !allowed.has(k));
58 assert.deepEqual(undeclared, [],
59 `${label}: undeclared AS2/JSON-LD term(s) — declare in AP_CONTEXT (extension) or the AS2 allowlist: ${undeclared.join(', ')}`);
60}
61
62// Seed one site that exercises the extension-heavy actor fields (profile links → PropertyValue,
63// photo → icon, primary → featured).
64db.prepare('INSERT INTO users (id, username, email, password_hash, role) VALUES (?,?,?,?,?)').run('u1', 'u1', 'u1@test', 'x', 'god');
65db.prepare('INSERT INTO sites (id, slug, title, owner_id, is_primary, profile_links, profile_photo) VALUES (?,?,?,?,?,?,?)')
66 .run('s1', 'demo', 'Demo', 'u1', 1, JSON.stringify([{ platform: 'website', url: 'https://x.test' }]), '/media/x.png');
67const site = db.prepare('SELECT * FROM sites WHERE id = ?').get('s1');
68site.primary_slug = 'demo';
69
70// Kitchen-sink note: nsfw (→ sensitive + summary), a hashtag (→ Hashtag), a cover (→ attachment).
71const post = {
72 id: 'p1', slug: 'hello', title: 'Hi', content: '<p>hello #music</p>',
73 nsfw: 1, content_warning: 'cw', tags: JSON.stringify(['mood']),
74 cover_image_url: '/media/c.webp', cover_alt: 'A cover', language: 'en',
75 published_at: '2026-01-01T00:00:00Z', created_at: '2026-01-01T00:00:00Z',
76};
77
78test('actor is valid AS2 (every term declared)', () => assertValid(AP.buildActor(BASE, site), 'actor'));
79test('create+note is valid AS2 (every term declared)', () => assertValid(AP.buildCreate(BASE, site, post), 'create/note'));
80test('outbox/followers/featured collections are valid AS2', () => {
81 assertValid(AP.buildOutbox(BASE, site, [post]), 'outbox');
82 assertValid(AP.buildFollowers(BASE, site, 3), 'followers');
83 assertValid(AP.buildFollowing(BASE, site, 2), 'following');
84 assertValid(AP.buildFeatured(BASE, site, [post]), 'featured');
85});
86test('AP_CONTEXT declares every extension term we rely on', () => {
87 for (const t of ['sensitive', 'Hashtag', 'manuallyApprovesFollowers', 'discoverable', 'featured', 'PropertyValue', 'embedUrl'])
88 assert.ok(ctxTerms.has(t), `AP_CONTEXT must declare "${t}"`);
89});
Note: See TracBrowser for help on using the repository browser.