source: Klonkt/src/server.js@ e056e56

main
Last change on this file since e056e56 was 16b0c00, checked in by roboburr <roboburr@…>, 3 months ago

fix(embed): Spotify API via CSP whitelist + faster fallback

Diagnosis (measured live): the loader open.spotify.com (200) loads the real
API bundle from embed-cdn.spotifycdn.com, which was NOT in our CSP scriptSrc
→ API never init → 8s wait before the bare iframe = "sluggish". Not an
ad-blocker issue.

  • CSP: *.spotifycdn.com added to scriptSrc + connectSrc (+ *.scdn.co).
  • Spotify API timeout 8s → 4s so the iframe fallback appears quickly if the API still doesn't initialise (CDN 503 / origin gating).

buster embed-player.js?v=5.

Co-Authored-By: Claude <noreply@…>

  • Property mode set to 100644
File size: 20.3 KB
Line 
1/**
2 * Klonkt Beta — server bootstrap
3 *
4 * Persoonlijk multi-site platform — Node + SQLite + htmx.
5 * Stack: Express + better-sqlite3 + EJS + htmx + ws.
6 */
7
8import 'dotenv/config';
9import express from 'express';
10import helmet from 'helmet';
11import session from 'express-session';
12import bodyParser from 'body-parser';
13import path from 'path';
14import fs from 'fs';
15import { fileURLToPath } from 'url';
16import http from 'http';
17import db, { initializeDatabase } from './config/database.js';
18import { startScheduler } from './services/Scheduler.js';
19import { SqliteSessionStore } from './services/SqliteSessionStore.js';
20import { ensurePrimarySite } from './services/ensurePrimarySite.js';
21import PrutterService from './services/PrutterService.js';
22import { WebSocketServer } from 'ws';
23
24import { resolveSite, loadAudioTracks, loadTheme } from './middleware/site.js';
25import { isViewer } from './middleware/auth.js';
26import { renderPage } from './middleware/render.js';
27import authRoutes from './routes/auth.js';
28import accountRoutes from './routes/account.js';
29import adminRoutes from './routes/admin.js';
30import adminAudioRoutes from './routes/admin-audio.js';
31import adminPlaylistsRoutes from './routes/admin-playlists.js';
32import adminSitesRoutes from './routes/admin-sites.js';
33import adminUsersRoutes from './routes/admin-users.js';
34import adminCommentsRoutes from './routes/admin-comments.js';
35import adminSettingsRoutes from './routes/admin-settings.js';
36import adminSeoRoutes from './routes/admin-seo.js';
37import prutterRoutes from './routes/prutter.js';
38import audioRoutes from './routes/audio.js';
39import searchRoutes from './routes/search.js';
40import commentsRoutes from './routes/comments.js';
41import tagsRoutes from './routes/tags.js';
42import typesRoutes from './routes/types.js';
43import usersRoutes from './routes/users.js';
44import feedRoutes from './routes/feed.js';
45import hubRoutes from './routes/hub.js';
46import artistsRoutes from './routes/artists.js';
47import postsRoutes from './routes/posts.js';
48import federationRoutes from './routes/federation.js';
49import { startCircleSyncLoop } from './services/CircleService.js';
50import adminCircleRoutes from './routes/admin-circle.js';
51import adminUpdatesRoutes from './routes/admin-updates.js';
52import adminPatreonRoutes from './routes/admin-patreon.js';
53import adminStatsRoutes from './routes/admin-stats.js';
54import circleRoutes from './routes/circle.js';
55import epkRoutes from './routes/epk.js';
56import newsletterRoutes from './routes/newsletter.js';
57import adminNewsletterRoutes from './routes/admin-newsletter.js';
58import downloadRoutes from './routes/download.js';
59import linkbioRoutes from './routes/linkbio.js';
60import embedRoutes from './routes/embed.js';
61import showsRoutes from './routes/shows.js';
62import adminShowsRoutes from './routes/admin-shows.js';
63import changelogRoutes from './routes/changelog.js';
64
65if (!process.env.SESSION_SECRET) {
66 console.error('❌ FATAL: SESSION_SECRET is required');
67 process.exit(1);
68}
69
70if (process.env.NODE_ENV === 'production' && process.env.SESSION_SECRET.length < 32) {
71 console.error('❌ FATAL: SESSION_SECRET too weak for production');
72 process.exit(1);
73}
74
75const __dirname = path.dirname(fileURLToPath(import.meta.url));
76const PORT = process.env.PORT || 3000;
77const isDev = process.env.NODE_ENV !== 'production';
78
79const app = express();
80const server = http.createServer(app);
81
82app.use(helmet({
83 contentSecurityPolicy: {
84 directives: {
85 defaultSrc: ["'self'"],
86 scriptSrc: [
87 "'self'",
88 "'unsafe-inline'",
89 // Eigen custom-embeds (embed-player.js) laden de OFFICIELE player-API's
90 // van deze hosts. Zonder deze whitelist blokkeert de CSP ze stil (alleen
91 // een console-fout) en faalt de embed-speler.
92 "https://www.youtube.com", // YouTube IFrame Player API (+ www-widgetapi.js)
93 "https://s.ytimg.com", // YouTube player-assets
94 "https://w.soundcloud.com", // SoundCloud Widget API (api.js)
95 "https://open.spotify.com", // Spotify iFrame API (loader)
96 "https://*.spotifycdn.com", // Spotify iFrame API (echte bundle: embed-cdn.spotifycdn.com)
97 ],
98 // Helmet's default zet script-src-attr op 'none', wat ALLE inline event-
99 // handlers (onchange/onclick/onsubmit) blokkeert — daardoor deed o.a. de
100 // avatar-upload (<input onchange="this.form.submit()">) en de rol-dropdown
101 // niets. We staan inline handlers expliciet toe, consistent met de al
102 // toegestane inline <script> hierboven.
103 scriptSrcAttr: ["'unsafe-inline'"],
104 styleSrc: ["'self'", "'unsafe-inline'"],
105 imgSrc: ["'self'", "data:", "https:"],
106 connectSrc: ["'self'", "wss:", "ws:", "https://*.spotifycdn.com", "https://*.scdn.co"],
107 // blob: is required for the audio player — it fetch()es track bytes and
108 // plays from a blob: object URL (Spotify-style). Without blob: here the
109 // CSP silently blocks <audio>.src = blob:… → the player fires 'error' and
110 // auto-skips every track. 'self'/https: do NOT imply blob:.
111 mediaSrc: ["'self'", "https:", "blob:"],
112 fontSrc: ["'self'"],
113 frameSrc: [
114 "'self'",
115 "https://open.spotify.com",
116 "https://w.soundcloud.com",
117 "https://bandcamp.com",
118 "https://embed.music.apple.com",
119 "https://www.youtube-nocookie.com",
120 "https://www.youtube.com", // YouTube IFrame API maakt soms een www.youtube.com-iframe
121 "https://player.vimeo.com",
122 ],
123 },
124 },
125 hsts: { maxAge: 31536000, includeSubDomains: true, preload: true },
126 frameguard: { action: 'sameorigin' },
127 referrerPolicy: { policy: 'no-referrer-when-downgrade' },
128}));
129
130app.set('view engine', 'ejs');
131app.set('views', path.join(__dirname, 'views'));
132
133app.use(bodyParser.urlencoded({ extended: true, limit: '10mb' }));
134app.use(bodyParser.json({ limit: '10mb' }));
135
136// Trust one upstream proxy in production. NPM (or Caddy / nginx) terminates
137// HTTPS and forwards to us over plain HTTP, setting X-Forwarded-Proto: https.
138// Without this, Express sees req.protocol === 'http' and won't issue secure
139// cookies — sessions never persist past the redirect after login.
140if (!isDev) app.set('trust proxy', 1);
141
142// Schema aanmaken/bijwerken VÓÓR iets de DB aanraakt: de session-store doet
143// bij constructie al een query op de `sessions`-tabel, dus bij een verse
144// install moeten de tabellen eerst bestaan (anders: "no such table: sessions"
145// → crash-loop op de allereerste boot).
146initializeDatabase();
147startScheduler(); // release-planning: zet geplande posts live zodra publish_at bereikt is
148
149// Vangnet: garandeer dat er altijd een primaire site is (solo/hub/circle).
150// Idempotent — doet niets als er al een site is of nog geen beheerder.
151ensurePrimarySite();
152
153// Session middleware extracted into a variable so the WebSocket upgrade
154// handler can reuse it (it needs req.session to authenticate sockets).
155const sessionMiddleware = session({
156 store: new SqliteSessionStore(),
157 secret: process.env.SESSION_SECRET,
158 resave: false,
159 saveUninitialized: false,
160 name: 'pcms.sid',
161 cookie: {
162 httpOnly: true,
163 secure: !isDev,
164 sameSite: 'lax',
165 maxAge: 30 * 24 * 60 * 60 * 1000,
166 },
167});
168app.use(sessionMiddleware);
169
170app.use('/assets', express.static(path.join(__dirname, 'assets'), { maxAge: isDev ? 0 : '1y' }));
171app.use('/media', express.static(process.env.MEDIA_PATH || './storage/media', {
172 // Publieke media (post-covers, avatars) moet door andere Klonkt-sites in hun
173 // CIRKEL cross-origin embedbaar zijn. Helmet zet standaard CORP=same-origin,
174 // wat die afbeeldingen in de browser blokkeert (bestand komt wél binnen, maar
175 // de browser weigert 'm te tonen). Voor /media dus expliciet cross-origin.
176 setHeaders: (res) => res.setHeader('Cross-Origin-Resource-Policy', 'cross-origin'),
177}));
178
179// (Verwijderd) TWA / digital-asset-links — alleen nodig voor de APK/TWA-variant.
180// Klonkt is PWA-only; geen assetlinks.json meer.
181
182// Cirkels: periodieke achtergrond-sync van remote instances (no-op tenzij tenancy='circle').
183startCircleSyncLoop();
184
185// Bundle HTMX: copy from node_modules into our own assets dir so we can serve
186// it locally (no third-party CDN). Idempotent — only copies if size differs.
187(function ensureLocalHtmx() {
188 const src = path.join(__dirname, '..', 'node_modules', 'htmx.org', 'dist', 'htmx.min.js');
189 const dest = path.join(__dirname, 'assets', 'js', 'htmx.min.js');
190 try {
191 const srcStat = fs.statSync(src);
192 const destStat = fs.existsSync(dest) ? fs.statSync(dest) : null;
193 if (!destStat || destStat.size !== srcStat.size) {
194 fs.copyFileSync(src, dest);
195 console.log(`📦 HTMX bundled locally: ${srcStat.size} bytes`);
196 }
197 } catch (e) {
198 console.warn('⚠️ Could not bundle HTMX:', e.message, '— run `npm install`');
199 }
200})();
201
202// Singleton PrutterService — routes get it via req.app.locals.prutter.
203const prutter = new PrutterService(db);
204app.locals.prutter = prutter;
205
206// Cirkels-federatie: publieke, site-agnostische endpoints (/.klonkt/*).
207// Vóór resolveSite/theme — ze hebben geen site-context nodig.
208app.use(federationRoutes);
209
210app.use(resolveSite);
211app.use(loadAudioTracks);
212app.use(loadTheme);
213
214// Lichtgewicht CSRF-defense: weiger cross-origin state-wijzigende requests.
215// Same-origin forms + HTMX sturen een matchende Origin; ontbreekt Origin dan
216// laten we door (non-browser clients). sameSite:'lax' op de sessiecookie is de
217// tweede laag. (Geldt niet voor GET/HEAD/OPTIONS.)
218app.use((req, res, next) => {
219 if (req.method === 'GET' || req.method === 'HEAD' || req.method === 'OPTIONS') return next();
220 const origin = req.get('origin');
221 if (!origin) return next(); // geen Origin -> geen browser-CSRF-vector
222 let originHost;
223 try { originHost = new URL(origin).host; } catch { return res.status(403).send('Ongeldige origin'); }
224 if (originHost !== req.get('host')) return res.status(403).send('Cross-origin request geweigerd');
225 next();
226});
227
228// Kijker-accounts: alles bekijken mag (incl. Beheer), niets wijzigen. Dit is de
229// ENIGE schrijf-blokkade — fail-closed, vóór alle route-handlers. Elke state-
230// wijzigende methode wordt geweigerd (de login-POST zet de sessie pas ná deze
231// guard, dus die valt er niet onder). I.p.v. rauwe 403-tekst tonen we een nette
232// pagina (of, bij HTMX, een ingeswapte melding).
233app.use((req, res, next) => {
234 const mutating = req.method !== 'GET' && req.method !== 'HEAD' && req.method !== 'OPTIONS';
235 if (mutating && isViewer(req.session?.user)) {
236 if (req.headers['hx-request'] === 'true') {
237 // htmx swapt niet op 4xx; stuur 200 + retarget zodat de melding in #pcms-main verschijnt.
238 res.setHeader('HX-Retarget', '#pcms-main');
239 res.setHeader('HX-Reswap', 'innerHTML');
240 res.status(200);
241 } else {
242 res.status(403);
243 }
244 return renderPage(req, res, 'pages/viewer-blocked', {
245 pageTitle: 'Kijker-modus',
246 bodyClass: 'on-special',
247 });
248 }
249 next();
250});
251
252app.use('/auth', authRoutes);
253app.use('/account', accountRoutes);
254app.use('/admin/audio', adminAudioRoutes);
255app.use('/admin/playlists', adminPlaylistsRoutes);
256app.use('/admin/sites', adminSitesRoutes);
257app.use('/admin/users', adminUsersRoutes);
258app.use('/admin/comments', adminCommentsRoutes);
259app.use('/admin/settings', adminSettingsRoutes);
260app.use('/admin/seo', adminSeoRoutes);
261app.use('/admin/circle', adminCircleRoutes);
262app.use('/admin/updates', adminUpdatesRoutes);
263app.use('/admin/patreon', adminPatreonRoutes);
264app.use('/admin/stats', adminStatsRoutes);
265app.use('/admin/newsletter', adminNewsletterRoutes);
266app.use('/admin/shows', adminShowsRoutes);
267app.use('/admin', adminRoutes);
268app.use('/prutter', prutterRoutes);
269app.use('/audio', audioRoutes);
270app.use('/search', searchRoutes);
271app.use('/comments', commentsRoutes);
272app.use('/tag', tagsRoutes);
273app.use('/type', typesRoutes);
274app.use('/users', usersRoutes);
275// Feed/sitemap routes are mounted at root because they're at well-known paths
276app.use('/', feedRoutes);
277app.use('/leden', artistsRoutes); // doorzoekbare leden-directory (alleen hub; solo: next())
278app.get('/artiesten', (req, res) => res.redirect(301, req.originalUrl.replace(/^\/artiesten/, '/leden'))); // oude URL -> /leden
279app.use('/', hubRoutes); // hub-overview op '/' (solo: next() -> postsRoutes)
280app.use('/', circleRoutes); // /cirkel-feed (solo/hub: next() -> postsRoutes)
281app.use('/', epkRoutes); // /pers perskit (premium; niet-premium: next() -> 404)
282app.use('/', newsletterRoutes); // /nieuwsbrief in/uitschrijven (premium; niet-premium: next())
283app.use('/', downloadRoutes); // /downloads + /download/:id download-voor-email (premium)
284app.use('/', linkbioRoutes); // /links link-in-bio + klikstats (premium)
285app.use('/', embedRoutes); // /embed inbedbare audiospeler (premium)
286app.use('/', showsRoutes); // /shows agenda + notify-me (premium)
287app.use('/', changelogRoutes); // /changelog publieke release-/wijzigingen-pagina
288app.use('/', postsRoutes);
289
290app.get('/manifest.webmanifest', (req, res) => {
291 const site = res.locals.site;
292
293 // PWA scope: confines installed apps to ONE site. If a user is in the
294 // bedrijf1 PWA and clicks a link to /sites/bedrijf2/..., the browser will
295 // open it in a regular tab (out-of-scope) instead of within the PWA.
296 // Same applies to APK packaging — the WebView is locked to this scope.
297 //
298 // For path-mounted sites: scope = /sites/<slug>/
299 // For root/subdomain sites: scope = /
300 const base = res.locals.siteUrlBase || ''; // '' or '/sites/<slug>'
301 const scope = (base || '') + '/';
302 const startUrl = (base || '') + '/?source=pwa';
303
304 // A stable identity per site so installs don't collide (Chromium uses `id`).
305 // NB: een id-wissel orphant bestaande PWA-installs (er is geen migratie die een
306 // install over een id-verandering heen tilt) — wie een site al als PWA had,
307 // moet 'm één keer opnieuw installeren. Data blijft server-side, dus niets kwijt.
308 const idBase = site?.slug ? `klonkt-${site.slug}` : 'klonkt';
309
310 res.set('Cache-Control', 'no-cache');
311 res.json({
312 id: idBase,
313 name: site?.title || 'Klonkt',
314 short_name: (site?.title || 'Klonkt').slice(0, 12),
315 description: site?.description || site?.tagline || '',
316 scope,
317 start_url: startUrl,
318 display: 'standalone',
319 display_override: ['standalone', 'minimal-ui'],
320 orientation: 'any',
321 background_color: '#1a1a17',
322 theme_color: site?.accent || '#c2410c',
323 lang: site?.language || 'nl',
324 icons: [
325 { src: '/favicon.svg', sizes: 'any', type: 'image/svg+xml' },
326 { src: '/favicon.ico', sizes: '64x64', type: 'image/x-icon' },
327 ],
328 // Hint to capable browsers: capture all in-scope links inside the PWA
329 capture_links: 'existing-client-navigate',
330 });
331});
332
333// Favicon — served as SVG so it picks up the site's accent color dynamically.
334// Browsers also request /favicon.ico by convention; we serve the same SVG
335// content there with a forgiving content-type since modern browsers accept it.
336function _renderFavicon(res, accent) {
337 const safeAccent = /^#[0-9a-fA-F]{3,8}$/.test(accent) ? accent : '#c2410c';
338 // Site mark: rounded square in the site accent + bold white 'K' (Klonkt)
339 const svg = `<?xml version="1.0" encoding="UTF-8"?>
340<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64">
341 <rect width="64" height="64" rx="14" fill="${safeAccent}"/>
342 <text x="50%" y="50%" dy="0.35em" text-anchor="middle"
343 font-family="Arial, Helvetica, sans-serif"
344 font-size="42" font-weight="800" fill="#fff">K</text>
345</svg>`;
346 res.set('Content-Type', 'image/svg+xml');
347 res.set('Cache-Control', 'public, max-age=86400');
348 res.send(svg);
349}
350
351app.get('/favicon.svg', (req, res) => {
352 _renderFavicon(res, res.locals.site?.accent);
353});
354app.get('/favicon.ico', (req, res) => {
355 // Browsers requesting .ico will accept SVG content; chrome/firefox both fine.
356 // Keeping the route prevents 404 spam in the console.
357 _renderFavicon(res, res.locals.site?.accent);
358});
359
360app.get('/sw.js', (req, res) => {
361 res.set('Content-Type', 'application/javascript');
362 res.set('Cache-Control', 'no-cache');
363 res.send(`
364const CACHE_VERSION = 'pcms-v11-' + new Date().toISOString().split('T')[0];
365self.addEventListener('install', e => {
366 e.waitUntil(caches.open(CACHE_VERSION).then(c => c.addAll(['/'])));
367 self.skipWaiting();
368});
369self.addEventListener('activate', e => {
370 e.waitUntil(caches.keys().then(keys => Promise.all(
371 keys.filter(k => k !== CACHE_VERSION).map(k => caches.delete(k))
372 )));
373 self.clients.claim();
374});
375// ALLEEN navigaties (HTML-pagina's) onderscheppen, voor een offline-fallback.
376// Afbeeldingen, CSS, JS en /media NIET aanraken — laat de browser die native
377// afhandelen. Anders kon een mislukte netwerk-fetch terugvallen op een lege
378// cache-match (undefined) en zo een afbeelding "kapot" maken bij een gewone
379// refresh (hard reload omzeilt de SW en werkte daarom wél).
380self.addEventListener('fetch', e => {
381 if (e.request.method !== 'GET') return;
382 if (e.request.mode !== 'navigate') return; // alleen page-loads
383 e.respondWith(
384 fetch(e.request).catch(() => caches.match('/').then(r => r || Response.error()))
385 );
386});
387 `);
388});
389
390process.on('unhandledRejection', (reason) => {
391 console.error('⚠️ Unhandled Rejection:', reason);
392});
393
394app.use((err, req, res, next) => {
395 console.error('❌ Error:', err);
396 res.status(err.status || 500).send(
397 isDev ? `<pre>${err.stack || err.message}</pre>` : 'Internal Server Error'
398 );
399});
400
401app.use((req, res) => {
402 res.status(404);
403 // Nette, mobielvriendelijke 404 via de shell (viewport + nav + huisstijl).
404 // Valt terug op kale HTML als het renderen onverhoopt faalt.
405 try {
406 return renderPage(req, res, 'pages/404', {
407 pageTitle: '404 — niet gevonden',
408 bodyClass: 'on-special on-404',
409 });
410 } catch (e) {
411 return res.send('<!doctype html><meta name="viewport" content="width=device-width,initial-scale=1"><div style="font-family:system-ui;max-width:500px;margin:4rem auto;text-align:center;padding:2rem"><h1 style="font-size:4rem;margin:0">404</h1><p>Pagina niet gevonden</p><a href="/">← Home</a></div>');
412 }
413});
414
415// ==================== WebSocket: Prutter real-time ====================
416// Authenticate via the existing session cookie. We reuse sessionMiddleware
417// during the HTTP upgrade so req.session is populated; if no user, abort.
418const wss = new WebSocketServer({ noServer: true });
419
420server.on('upgrade', (req, socket, head) => {
421 if (req.url !== '/ws/prutter') {
422 socket.destroy();
423 return;
424 }
425 // Run session middleware on the upgrade request.
426 // (Express's middleware accepts (req, res, next); we pass a stub res.)
427 const stubRes = { setHeader: () => {}, getHeader: () => undefined, on: () => {}, end: () => {} };
428 sessionMiddleware(req, stubRes, () => {
429 if (!req.session?.user) {
430 socket.write('HTTP/1.1 401 Unauthorized\r\n\r\n');
431 socket.destroy();
432 return;
433 }
434 // Kijker-accounts zijn alleen-lezen: weiger de WS-upgrade. De HTTP-guard
435 // dekt geen WS, dus dit is de plek om schrijven via een (toekomstige)
436 // message-handler te voorkomen.
437 if (isViewer(req.session.user)) {
438 socket.write('HTTP/1.1 403 Forbidden\r\n\r\n');
439 socket.destroy();
440 return;
441 }
442 wss.handleUpgrade(req, socket, head, (ws) => {
443 ws.userId = req.session.user.id;
444 wss.emit('connection', ws, req);
445 });
446 });
447});
448
449wss.on('connection', (ws) => {
450 prutter.addConnection(ws.userId, ws);
451 ws.on('close', () => prutter.removeConnection(ws.userId, ws));
452 ws.on('error', () => prutter.removeConnection(ws.userId, ws));
453 // Optional: ping every 30s to keep connections alive through proxies
454 ws.isAlive = true;
455 ws.on('pong', () => { ws.isAlive = true; });
456});
457const wsPing = setInterval(() => {
458 for (const ws of wss.clients) {
459 if (ws.isAlive === false) { ws.terminate(); continue; }
460 ws.isAlive = false;
461 try { ws.ping(); } catch {}
462 }
463}, 30000);
464if (wsPing.unref) wsPing.unref();
465
466server.listen(PORT, () => {
467 console.log('');
468 console.log('🪶 Klonkt Beta');
469 console.log(` http://localhost:${PORT}`);
470 console.log('');
471 console.log(` ✓ Security: Helmet, CSP, secure sessions`);
472 console.log(` ✓ Privacy: Self-hosted fonts, no third-party requests`);
473 console.log(` ✓ Layout: v9 editorial feel (top nav, profile header)`);
474 console.log(` ✓ Auth: wachtwoord (beheer) + Google (luisteraars) / logout`);
475 console.log(` ✓ Posts: create / edit / view / archive`);
476 console.log(` ✓ Realtime: WebSocket server ready (Prutter)`);
477 console.log('');
478 console.log(` Mode: ${isDev ? 'development' : 'PRODUCTION'}`);
479 console.log('');
480});
481
482export default app;
Note: See TracBrowser for help on using the repository browser.