source: Klonkt/src/routes/auth.js@ 1080d14

main
Last change on this file since 1080d14 was b919a67, checked in by roboburr <roboburr@…>, 3 months ago

auth: all Google login errors as clear explanation blocks (codes instead of bare alert)

The Google callback now redirects with ?gerr=<code> (admin/session/email/linked/
unavailable/failed) and auth-login.ejs maps each code to a clear explanation block
with icon + heading + text (admin gets the two login paths as well). Completes the
error indication consistently; free-form ?error= text remains as fallback for the
regular alert.

Co-Authored-By: Claude <noreply@…>

  • Property mode set to 100644
File size: 13.6 KB
RevLine 
[7bc636b]1import express from 'express';
2import crypto from 'crypto';
[9e27d64]3import bcrypt from 'bcryptjs';
[7bc636b]4import { v4 as uuid } from 'uuid';
5import db from '../config/database.js';
6import { renderPage } from '../middleware/render.js';
[9e27d64]7import { loginLimiter, registerLimiter } from '../middleware/rate-limit.js';
[7bc636b]8import { safeNext } from '../middleware/auth.js';
[9e27d64]9import { googleConfigured, authorizeUrl, exchangeCode, fetchUserinfo } from '../config/google.js';
[e9229f2]10import { premiumUnlocked } from '../services/PatreonService.js';
11
12// Fan-login (luisteraars inloggen met Google om te reageren) is een premium-
13// feature: beschikbaar als Google is ingesteld ÉN de premium-laag ontgrendeld is
14// (premium uit = vrij; aan = Patreon vereist).
15function fanLoginReady() {
16 return googleConfigured() && premiumUnlocked();
17}
[9e27d64]18import { mailerConfigured, sendMail } from '../config/mailer.js';
[7bc636b]19
20const router = express.Router();
21
[9e27d64]22// Vaste dummy-hash: zo draait login altijd één bcrypt-vergelijking, ook als de
23// user niet bestaat of geen wachtwoord heeft — geen timing-oracle voor enumeratie.
24const DUMMY_HASH = bcrypt.hashSync('constant-time-login-guard', 10);
25
26// Canonieke basis-URL voor links in e-mails (reset). Uit headers bouwen is
27// spoofbaar (X-Forwarded-Host); een vaste config sluit dat uit.
28function publicBaseUrl(req) {
29 const cfg = (process.env.PUBLIC_BASE_URL || '').replace(/\/$/, '');
30 if (cfg) return cfg;
31 // Fallback (dev): trust-proxy-gesaneerde protocol + Host-header (NIET de rauwe
32 // X-Forwarded-Host).
33 return `${req.protocol}://${req.get('host')}`;
34}
35
36function hashToken(raw) {
37 return crypto.createHash('sha256').update(String(raw)).digest('hex');
38}
39
40// Eerste-keer-setup? Pas zolang er nog geen enkele gebruiker is mag /register een
41// beheerder aanmaken. Daarna is registratie dicht (luisteraars komen via Google).
42function isSetupMode() {
43 return db.prepare('SELECT COUNT(*) AS c FROM users').get().c === 0;
44}
45
46// ==================== LOGIN (beheerder = wachtwoord) ====================
[7bc636b]47router.get('/login', (req, res) => {
48 const next = safeNext(req.query.next) || '';
49 if (req.session.user) return res.redirect(next || '/');
[9e27d64]50 if (isSetupMode()) return res.redirect('/auth/register' + (next ? '?next=' + encodeURIComponent(next) : ''));
[7bc636b]51 renderPage(req, res, 'pages/auth-login', {
[c80e78b]52 pageTitle: 'Inloggen',
[a7e12de]53 bodyClass: 'on-special on-auth',
[70679063]54 error: req.query.error || null,
55 gerr: req.query.gerr || null, // foutcode voor een rijkere uitleg (bv. 'admin')
[9e27d64]56 success: req.query.success || null,
57 username: '',
[e9229f2]58 googleReady: fanLoginReady(),
[7bc636b]59 next,
60 });
61});
62
[9e27d64]63router.post('/login', loginLimiter, (req, res) => {
64 const { username, password } = req.body;
65 const next = safeNext(req.body.next) || '';
66
67 const renderErr = (error, status = 400) => {
68 res.status(status);
69 return renderPage(req, res, 'pages/auth-login', {
70 pageTitle: 'Inloggen', bodyClass: 'on-special',
[e9229f2]71 error, success: null, username: username || '', googleReady: fanLoginReady(), next,
[9e27d64]72 });
73 };
74
75 if (!username || !password) return renderErr('Gebruikersnaam en wachtwoord vereist');
76
77 const user = db.prepare('SELECT * FROM users WHERE username = ? OR email = ?').get(username, username);
78 // Altijd één bcrypt-vergelijking (dummy als de user geen bruikbaar wachtwoord
79 // heeft) zodat de responstijd niets over het bestaan van een account verraadt.
80 const usable = !!(user && user.password_hash && user.password_hash !== '!google-oauth');
81 const ok = bcrypt.compareSync(password, usable ? user.password_hash : DUMMY_HASH);
82 if (!usable || !ok) return renderErr('Ongeldige inloggegevens', 401);
83
84 req.session.user = {
85 id: user.id, username: user.username, email: user.email, role: user.role,
86 avatar_url: user.avatar_url, palette: user.palette, theme: user.theme,
[640b39c]87 readonly: !!user.readonly,
[9e27d64]88 };
89 res.redirect(next || '/');
90});
91
92// ==================== EERSTE-KEER-SETUP (beheerder aanmaken) ====================
93router.get('/register', (req, res) => {
94 const next = safeNext(req.query.next) || '';
95 if (req.session.user) return res.redirect(next || '/');
96 // Geen publieke registratie: alleen de allereerste beheerder mag hier aangemaakt.
97 if (!isSetupMode()) return res.redirect('/auth/login' + (next ? '?next=' + encodeURIComponent(next) : ''));
98 renderPage(req, res, 'pages/auth-register', {
99 pageTitle: 'Beheerder aanmaken', bodyClass: 'on-special',
100 error: null, username: '', email: '', next,
101 });
102});
103
104router.post('/register', registerLimiter, (req, res) => {
105 const { username, email, password } = req.body;
106 const next = safeNext(req.body.next) || '';
107 const renderErr = (error) => renderPage(req, res, 'pages/auth-register', {
108 pageTitle: 'Beheerder aanmaken', bodyClass: 'on-special',
109 error, username: username || '', email: email || '', next,
110 });
111
112 // Hard gesloten zodra er een gebruiker is — voorkomt een tweede "admin" via deze route.
113 if (!isSetupMode()) return res.redirect('/auth/login');
114
115 if (!username || !email || !password) return renderErr('Alle velden zijn verplicht');
116 if (!/^[a-z0-9_-]{3,32}$/i.test(username)) {
117 return renderErr('Gebruikersnaam: 3-32 tekens, letters/cijfers/_/- alleen');
118 }
119 if (password.length < 8) return renderErr('Wachtwoord moet minstens 8 tekens zijn');
120
121 const userId = uuid();
122 const hash = bcrypt.hashSync(password, 10);
123 // De allereerste gebruiker is de beheerder (god).
124 db.prepare(`
125 INSERT INTO users (id, username, email, password_hash, role, theme, palette)
126 VALUES (?, ?, ?, ?, 'god', 'dark', 'sage')
127 `).run(userId, username, email, hash);
128
129 // Persoonlijke site auto-aanmaken (single-tenant-ombouw volgt later).
130 if (!db.prepare('SELECT 1 FROM sites LIMIT 1').get()) {
131 const siteId = uuid();
132 db.prepare(`
133 INSERT INTO sites (id, slug, title, description, owner_id, palette, accent, language)
134 VALUES (?, ?, ?, ?, ?, 'sage', '#c2410c', 'nl')
135 `).run(siteId, username.toLowerCase(), username + "'s Site", 'Welkom', userId);
136 db.prepare(`INSERT INTO site_members (site_id, user_id, role) VALUES (?, ?, 'admin')`).run(siteId, userId);
137 }
138
139 req.session.user = { id: userId, username, email, role: 'god', palette: 'sage', theme: 'dark' };
140 res.redirect(next || '/');
141});
142
143// ==================== WACHTWOORD VERGETEN (aanvraag) ====================
144router.get('/reset-request', (req, res) => {
145 if (req.session.user) return res.redirect('/');
146 renderPage(req, res, 'pages/auth-reset-request', {
147 pageTitle: 'Wachtwoord resetten', bodyClass: 'on-special',
148 error: null, sent: false, devResetUrl: null, mailer: mailerConfigured(),
149 });
150});
151
152router.post('/reset-request', registerLimiter, async (req, res) => {
153 const email = (req.body.email || '').trim().toLowerCase();
154 let devResetUrl = null;
155
156 if (email) {
157 const user = db.prepare('SELECT id, email FROM users WHERE LOWER(email) = ?').get(email);
158 if (user) {
159 const token = crypto.randomBytes(32).toString('hex'); // ruw: gaat alleen de mail/link in
160 const expires = new Date(Date.now() + 30 * 60 * 1000).toISOString(); // 30 min
161 // Alleen de HASH opslaan: DB-leestoegang levert zo geen bruikbaar token op.
162 db.prepare('UPDATE users SET reset_token = ?, reset_token_expires = ? WHERE id = ?')
163 .run(hashToken(token), expires, user.id);
164
165 const url = `${publicBaseUrl(req)}/auth/reset/${token}`;
166
167 if (mailerConfigured()) {
168 try {
169 await sendMail({
170 to: user.email,
171 subject: 'Wachtwoord resetten',
172 text: `Reset je wachtwoord via deze link (30 min geldig):\n\n${url}\n\nNiet aangevraagd? Negeer deze mail.`,
173 html: `<p>Reset je wachtwoord via deze link (30 min geldig):</p><p><a href="${url}">${url}</a></p><p>Niet aangevraagd? Negeer deze mail.</p>`,
174 });
175 } catch (e) {
176 console.error('[reset-request] mail faalde:', e.message);
177 }
178 } else if (process.env.NODE_ENV !== 'production') {
179 // Dev zonder SMTP: link in log + op de pagina tonen.
180 console.log(`[password-reset] ${user.email} -> ${url}`);
181 devResetUrl = url;
182 } else {
183 // Productie zonder SMTP: NOOIT het token loggen. Verwijs naar de CLI break-glass.
184 console.log(`[password-reset] aangevraagd voor ${user.email} (geen SMTP — gebruik 'npm run reset-admin')`);
185 }
186 }
187 }
188
189 // Anti-enumeratie: zelfde antwoord ongeacht of het adres bestaat.
190 renderPage(req, res, 'pages/auth-reset-request', {
191 pageTitle: 'Wachtwoord resetten', bodyClass: 'on-special',
192 error: null, sent: true, devResetUrl, mailer: mailerConfigured(),
193 });
194});
195
196// ==================== WACHTWOORD RESETTEN (toepassen) ====================
197router.get('/reset/:token', (req, res) => {
198 const row = db.prepare(`
199 SELECT id, username FROM users
200 WHERE reset_token = ? AND reset_token_expires > datetime('now')
201 `).get(hashToken(req.params.token));
202 renderPage(req, res, 'pages/auth-reset', {
203 pageTitle: 'Wachtwoord resetten', bodyClass: 'on-special',
204 error: row ? null : 'Deze reset-link is ongeldig of verlopen.',
205 token: row ? req.params.token : null,
206 username: row ? row.username : null,
207 });
208});
209
210router.post('/reset/:token', (req, res) => {
211 const { new_password, confirm } = req.body;
212 const row = db.prepare(`
213 SELECT id, username FROM users
214 WHERE reset_token = ? AND reset_token_expires > datetime('now')
215 `).get(hashToken(req.params.token));
216
217 const renderError = (msg) => renderPage(req, res, 'pages/auth-reset', {
218 pageTitle: 'Wachtwoord resetten', bodyClass: 'on-special',
219 error: msg, token: row ? req.params.token : null, username: row ? row.username : null,
220 });
221
222 if (!row) return renderError('Deze reset-link is ongeldig of verlopen.');
223 if (!new_password || new_password.length < 8) return renderError('Wachtwoord moet minstens 8 tekens zijn');
224 if (new_password !== confirm) return renderError('Wachtwoorden komen niet overeen');
225
226 const hash = bcrypt.hashSync(new_password, 10);
227 db.prepare(`
228 UPDATE users SET password_hash = ?, reset_token = NULL, reset_token_expires = NULL,
229 updated_at = CURRENT_TIMESTAMP WHERE id = ?
230 `).run(hash, row.id);
231 res.redirect('/auth/login?success=' + encodeURIComponent('Wachtwoord gereset — log nu in.'));
232});
233
234// ==================== GOOGLE-LOGIN (luisteraars/reageerders) ====================
235// Per-instance, eigen Google-client. Geeft ALTIJD rol member — nooit beheer.
[c80e78b]236router.get('/google', (req, res) => {
[e9229f2]237 if (!fanLoginReady()) {
[b919a67]238 return res.redirect('/auth/login?gerr=unavailable');
[7bc636b]239 }
[9e27d64]240 const state = crypto.randomBytes(16).toString('hex');
241 req.session.oauthState = state;
242 req.session.oauthNext = safeNext(req.query.next) || '';
243 res.redirect(authorizeUrl(state));
[7bc636b]244});
245
[c80e78b]246function uniqueUsername(base) {
247 let u = String(base || 'luisteraar').toLowerCase().replace(/[^a-z0-9_-]/g, '').slice(0, 28);
248 if (u.length < 3) u = 'luisteraar';
249 let candidate = u, n = 1;
250 while (db.prepare('SELECT 1 FROM users WHERE username = ?').get(candidate)) {
251 candidate = (u.slice(0, 26) + n).slice(0, 32);
252 n++;
[7bc636b]253 }
[c80e78b]254 return candidate;
255}
256
257router.get('/google/callback', async (req, res) => {
[b919a67]258 const fail = (code) => res.redirect('/auth/login?gerr=' + code);
259 if (!fanLoginReady()) return fail('unavailable');
[c80e78b]260 try {
[9e27d64]261 const { code, state } = req.query;
[b919a67]262 if (!code || !state || state !== req.session.oauthState) return fail('session');
[9e27d64]263 const next = safeNext(req.session.oauthNext) || '';
264 delete req.session.oauthState;
265 delete req.session.oauthNext;
[32cc601]266
[9e27d64]267 const tok = await exchangeCode(String(code));
268 const info = await fetchUserinfo(tok.access_token);
269 const email = (info.email || '').trim().toLowerCase();
[b919a67]270 if (!email || info.email_verified === false) return fail('email');
[7bc636b]271
[c80e78b]272 let user = db.prepare('SELECT * FROM users WHERE LOWER(email) = ?').get(email);
273
[9e27d64]274 if (user) {
275 // Strikte scheiding: Google geeft nooit beheer. Hoort dit adres bij een
276 // beheerder, dan moet diegene met wachtwoord inloggen (geen Google-bypass).
277 if (user.role === 'god' || user.role === 'admin') {
[70679063]278 // Eigen, duidelijke uitleg-pagina (zie auth-login.ejs) i.p.v. een kale melding.
[b919a67]279 return fail('admin');
[c80e78b]280 }
[9e27d64]281 // Bestaande luisteraar: koppel google_sub/avatar als die ontbreken; weiger
282 // als al aan een ander Google-account gekoppeld.
283 if (user.google_sub && info.sub && user.google_sub !== info.sub) {
[b919a67]284 return fail('linked');
[32cc601]285 }
[c80e78b]286 db.prepare(`
[9e27d64]287 UPDATE users SET google_sub = COALESCE(google_sub, ?), avatar_url = COALESCE(avatar_url, ?),
288 updated_at = CURRENT_TIMESTAMP WHERE id = ?
289 `).run(info.sub || null, info.picture || null, user.id);
290 } else {
291 // Nieuwe luisteraar — altijd member.
292 const userId = uuid();
293 const username = uniqueUsername(info.name || email.split('@')[0]);
294 db.prepare(`
295 INSERT INTO users (id, username, email, password_hash, role, avatar_url, theme, palette, google_sub)
296 VALUES (?, ?, ?, '!google-oauth', 'member', ?, 'dark', 'sage', ?)
297 `).run(userId, username, info.email || email, info.picture || null, info.sub || null);
298 user = db.prepare('SELECT * FROM users WHERE id = ?').get(userId);
[c80e78b]299 }
[7bc636b]300
[c80e78b]301 req.session.user = {
[9e27d64]302 id: user.id, username: user.username, email: user.email, role: user.role,
303 avatar_url: user.avatar_url, palette: user.palette, theme: user.theme,
[640b39c]304 readonly: !!user.readonly,
[c80e78b]305 };
306 res.redirect(next || '/');
307 } catch (e) {
308 console.error('[auth/google/callback]', e.message);
[b919a67]309 fail('failed');
[7bc636b]310 }
311});
312
313// ==================== LOGOUT ====================
[9e27d64]314router.get('/logout', (req, res) => { req.session.destroy(() => res.redirect('/')); });
315router.post('/logout', (req, res) => { req.session.destroy(() => res.redirect('/')); });
[7bc636b]316
317export default router;
Note: See TracBrowser for help on using the repository browser.