source: Klonkt/src/routes/admin-sites.js@ 7881080

main
Last change on this file since 7881080 was 7881080, checked in by roboburr <roboburr@…>, 3 months ago

Hub #3: explicit is_primary flag + shared getPrimarySite() (DRY)

The "oldest site = primary site" assumption was duplicated independently in
resolveSite, hub.js, account.js and admin.js (fragile: if the oldest happened
to be an artist site, the hub home would be wrong). Now:

  • sites.is_primary column + backfill (marks the oldest if none is primary yet; ensurePrimarySite sets it on fresh installs) → existing behaviour exactly preserved.
  • one getPrimarySite() helper (is_primary, fallback oldest) replaces the 4 copies.
  • god can CHOOSE the primary/main site: ★ button + "primary" badge on /admin/sites (exactly one primary via a transaction).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@…>

  • Property mode set to 100644
File size: 14.6 KB
Line 
1/**
2 * Admin: Site management — Phase E.
3 *
4 * GET /admin/sites -> list all sites
5 * GET /admin/sites/new -> create form
6 * POST /admin/sites/create -> insert + redirect to edit
7 * GET /admin/sites/:slug/edit -> edit form
8 * POST /admin/sites/:slug/save -> update
9 * POST /admin/sites/:slug/delete-> delete (refuses if site has posts)
10 *
11 * God-only (requireGod middleware). Slug is immutable after create — too
12 * many things hang off it (URLs, manifest scope, federation). If you really
13 * need to rename: delete + re-create.
14 */
15
16import express from 'express';
17import path from 'path';
18import fs from 'fs';
19import { fileURLToPath } from 'url';
20import multer from 'multer';
21import { v4 as uuid } from 'uuid';
22import db from '../config/database.js';
23import { renderPage } from '../middleware/render.js';
24import { requireGod, requireAuth, requireSiteManagerBySlug } from '../middleware/auth.js';
25import ThemeService from '../services/ThemeService.js';
26import { listPlatforms, PLATFORMS } from '../services/PlatformIcons.js';
27
28const __dirname = path.dirname(fileURLToPath(import.meta.url));
29
30// Profile photos share the avatar directory with user avatars — same physical
31// folder, same URL prefix. Filenames are uuid-prefixed so site photos and
32// user avatars never collide.
33const PHOTO_DIR = path.resolve(
34 process.env.AVATAR_PATH || path.join(__dirname, '..', '..', 'storage', 'media', 'avatars')
35);
36fs.mkdirSync(PHOTO_DIR, { recursive: true });
37
38const ALLOWED_PHOTO_EXT = new Set(['.jpg', '.jpeg', '.png', '.webp', '.gif']);
39const MAX_PHOTO_BYTES = 5 * 1024 * 1024;
40const photoUpload = multer({
41 storage: multer.diskStorage({
42 destination: (req, file, cb) => cb(null, PHOTO_DIR),
43 filename: (req, file, cb) => {
44 const ext = path.extname(file.originalname || '').toLowerCase() || '.jpg';
45 cb(null, `site-${uuid()}${ext}`);
46 },
47 }),
48 limits: { fileSize: MAX_PHOTO_BYTES },
49 fileFilter: (req, file, cb) => {
50 const ext = path.extname(file.originalname || '').toLowerCase();
51 if (!ALLOWED_PHOTO_EXT.has(ext)) {
52 return cb(new Error('Alleen JPG/PNG/WebP/GIF toegestaan'));
53 }
54 cb(null, true);
55 },
56});
57
58/** Coerce req.body fields into the JSON profile_links array. */
59function buildProfileLinks(body) {
60 const platforms = body.profile_link_platform || [];
61 const urls = body.profile_link_url || [];
62 const arr = [];
63 const platformsArr = Array.isArray(platforms) ? platforms : [platforms];
64 const urlsArr = Array.isArray(urls) ? urls : [urls];
65 for (let i = 0; i < platformsArr.length; i++) {
66 const p = (platformsArr[i] || '').toString().trim();
67 const u = (urlsArr[i] || '').toString().trim();
68 if (!p || !u) continue;
69 if (!PLATFORMS[p]) continue;
70 if (!/^https?:\/\//i.test(u) && p !== 'email') continue;
71 if (p === 'email' && !/^mailto:|^[^\s@]+@[^\s@]+$/i.test(u)) continue;
72 arr.push({ platform: p, url: u });
73 }
74 return arr.length ? JSON.stringify(arr) : null;
75}
76
77const router = express.Router();
78
79// ==================== UPLOAD PROFILE PHOTO (JSON) ====================
80// POST /admin/sites/upload-photo → { ok: true, url: '/media/avatars/<filename>' }
81// Used by the admin-site-edit form's photo picker. The form itself still
82// holds the URL string in `profile_photo` — this endpoint just stores the
83// file and hands back a URL that the form can paste into the input field.
84router.post('/upload-photo', requireAuth, (req, res) => {
85 photoUpload.single('photo')(req, res, (err) => {
86 if (err) return res.status(400).json({ ok: false, error: err.message });
87 if (!req.file) return res.status(400).json({ ok: false, error: 'Geen bestand ontvangen' });
88 res.json({
89 ok: true,
90 url: `/media/avatars/${req.file.filename}`,
91 size: req.file.size,
92 mime: req.file.mimetype,
93 });
94 });
95});
96
97const RESERVED_SITE_SLUGS = new Set([
98 'auth', 'admin', 'login', 'register', 'logout', 'archive', 'search',
99 'account', 'sites', 'comments', 'posts', 'media', 'audio', 'prutter',
100 'forum', 'tag', 'user', 'users', 'artiesten', 'leden', 'feed.xml', 'atom.xml', 'sitemap.xml',
101 'manifest.webmanifest', 'sw.js', 'favicon.ico', 'favicon.svg', 'assets',
102]);
103
104function siteEditableFields() {
105 return {
106 title: '',
107 description: '',
108 tagline: '',
109 language: 'nl',
110 palette: 'sage',
111 accent: '#c2410c',
112 profile_photo: '',
113 profile_enabled: 1,
114 profile_name: '',
115 profile_bio: '',
116 is_public: 1,
117 robots_index: 1,
118 require_login_to_comment: 0,
119 enable_audio_player: 1,
120 enable_prutter: 1,
121 comments_moderation_mode: 'moderate',
122 feed_view_default: 'grid',
123 feed_view_switch: 1,
124 show_search: 1,
125 show_archive_link: 1,
126 title_template: '{title} — {site}',
127 twitter: '',
128 canonical: '',
129 google_verification: '',
130 bing_verification: '',
131 pinterest_verification: '',
132 yandex_verification: '',
133 custom_css: '',
134 custom_head_html: '',
135 custom_foot_html: '',
136 };
137}
138
139/** Geldige user-id voor owner-toewijzing, of null bij leeg/onbekend. */
140function validOwnerId(raw) {
141 const id = (raw || '').toString().trim();
142 if (!id) return null;
143 return db.prepare('SELECT 1 FROM users WHERE id = ?').get(id) ? id : null;
144}
145
146/** Geef een user admin-rechten op een site (idempotent upsert). */
147function grantSiteAdmin(siteId, userId) {
148 db.prepare(`
149 INSERT INTO site_members (site_id, user_id, role) VALUES (?, ?, 'admin')
150 ON CONFLICT(site_id, user_id) DO UPDATE SET role = 'admin'
151 `).run(siteId, userId);
152}
153
154/** Kandidaat-owners voor het owner-keuzeveld (god-only). */
155function listOwnerCandidates() {
156 return db.prepare('SELECT id, username, role FROM users ORDER BY username').all();
157}
158
159// ==================== LIST ====================
160router.get('/', requireGod, (req, res) => {
161 const sites = db.prepare(`
162 SELECT s.id, s.slug, s.title, s.description, s.created_at,
163 s.is_public, s.robots_index, s.is_primary,
164 u.username AS owner_username,
165 (SELECT COUNT(*) FROM posts WHERE site_id = s.id) AS post_count
166 FROM sites s LEFT JOIN users u ON u.id = s.owner_id
167 ORDER BY s.is_primary DESC, s.created_at DESC
168 `).all();
169
170 renderPage(req, res, 'pages/admin-sites', {
171 pageTitle: 'Sites',
172 bodyClass: 'on-admin',
173 sites,
174 success: req.query.success || null,
175 error: req.query.error || null,
176 });
177});
178
179// ==================== NEW (form) ====================
180router.get('/new', requireGod, (req, res) => {
181 renderPage(req, res, 'pages/admin-site-edit', {
182 pageTitle: 'New site',
183 bodyClass: 'on-admin',
184 isNew: true,
185 site: { slug: '', owner_id: req.session.user.id, ...siteEditableFields() },
186 users: listOwnerCandidates(),
187 palettes: ThemeService.listPalettes(),
188 accents: ThemeService.listAccents(),
189 platforms: listPlatforms(),
190 parsedLinks: [],
191 error: null,
192 });
193});
194
195// ==================== CREATE ====================
196router.post('/create', requireGod, (req, res) => {
197 const slug = (req.body.slug || '').toString().toLowerCase().trim();
198 if (!/^[a-z0-9_-]{2,40}$/.test(slug)) {
199 return res.redirect('/admin/sites/new?error=' + encodeURIComponent('Slug: 2-40 chars, letters/numbers/underscore/dash'));
200 }
201 if (RESERVED_SITE_SLUGS.has(slug)) {
202 return res.redirect('/admin/sites/new?error=' + encodeURIComponent('That slug is reserved'));
203 }
204 const existing = db.prepare('SELECT id FROM sites WHERE slug = ?').get(slug);
205 if (existing) {
206 return res.redirect('/admin/sites/new?error=' + encodeURIComponent('Slug already taken'));
207 }
208
209 const f = { ...siteEditableFields(), ...req.body };
210
211 // Owner: god mag de site aan een ANDERE gebruiker toewijzen — dit is de kern
212 // van hub-modus (elke gebruiker z'n eigen, zelf te beheren Klonkt). Leeg of
213 // ongeldig → de aanmakende god zelf.
214 const ownerId = validOwnerId(req.body.owner_id) || req.session.user.id;
215
216 const siteId = uuid();
217 db.prepare(`
218 INSERT INTO sites (
219 id, slug, title, description, tagline, owner_id,
220 language, palette, accent, profile_photo,
221 is_public, robots_index, require_login_to_comment, enable_audio_player,
222 feed_view_default, comments_moderation_mode
223 ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
224 `).run(
225 siteId, slug,
226 (f.title || slug).slice(0, 200),
227 (f.description || '').slice(0, 500),
228 (f.tagline || '').slice(0, 200),
229 ownerId,
230 f.language || 'nl',
231 f.palette || 'sage',
232 ThemeService.validateAccent(f.accent) || '#c2410c',
233 f.profile_photo || null,
234 f.is_public ? 1 : 0,
235 f.robots_index ? 1 : 0,
236 f.require_login_to_comment ? 1 : 0,
237 (f.enable_audio_player !== undefined ? (f.enable_audio_player ? 1 : 0) : 1),
238 f.feed_view_default === 'timeline' ? 'timeline' : 'grid',
239 f.comments_moderation_mode === 'trust' ? 'trust' : 'moderate',
240 );
241
242 // De OWNER (niet per se de aanmaker) krijgt een site_members-admin-rij → zo komt
243 // 'ie door canAdminSite + de requireSiteManager-gates en beheert 'ie z'n site.
244 grantSiteAdmin(siteId, ownerId);
245
246 res.redirect(`/admin/sites/${slug}/edit?success=` + encodeURIComponent('Site aangemaakt'));
247});
248
249// ==================== EDIT (form) ====================
250router.get('/:slug/edit', requireSiteManagerBySlug, (req, res) => {
251 const site = db.prepare('SELECT * FROM sites WHERE slug = ?').get(req.params.slug);
252 if (!site) return res.redirect('/admin/sites?error=Not+found');
253
254 let parsedLinks = [];
255 if (site.profile_links) {
256 try { parsedLinks = JSON.parse(site.profile_links) || []; } catch {}
257 }
258
259 renderPage(req, res, 'pages/admin-site-edit', {
260 pageTitle: `Edit: ${site.title}`,
261 bodyClass: 'on-admin',
262 isNew: false,
263 site,
264 users: listOwnerCandidates(),
265 palettes: ThemeService.listPalettes(),
266 accents: ThemeService.listAccents(),
267 platforms: listPlatforms(),
268 parsedLinks,
269 success: req.query.success || null,
270 error: req.query.error || null,
271 });
272});
273
274// ==================== SAVE ====================
275router.post('/:slug/save', requireSiteManagerBySlug, (req, res) => {
276 const site = db.prepare('SELECT id FROM sites WHERE slug = ?').get(req.params.slug);
277 if (!site) return res.redirect('/admin/sites?error=Not+found');
278
279 const f = req.body;
280 const moderationMode = f.comments_moderation_mode === 'moderate' ? 'moderate' : 'trust';
281 const feedViewDef = f.feed_view_default === 'grid' ? 'grid' : 'timeline';
282 const profileLinksJson = buildProfileLinks(f);
283
284 // theme_override: only accept the three legal values. Empty string means
285 // "Auto" — defer to user's prefers-color-scheme on first paint.
286 const themeOverride = ['light', 'dark'].includes(f.theme_override) ? f.theme_override : '';
287
288 // accent: only accept colors from the curated ACCENTS list. Falls back to
289 // the orange default if the submitted value isn't recognised.
290 const accent = ThemeService.validateAccent(f.accent) || '#c2410c';
291
292 db.prepare(`
293 UPDATE sites SET
294 title = ?, description = ?, tagline = ?, language = ?,
295 palette = ?, accent = ?, theme_override = ?, profile_photo = ?,
296 profile_enabled = ?,
297 profile_links = ?,
298 is_public = ?, robots_index = ?, require_login_to_comment = ?,
299 enable_audio_player = ?, enable_prutter = ?,
300 comments_moderation_mode = ?,
301 feed_view_default = ?, feed_view_switch = ?,
302 show_search = ?, show_archive_link = ?,
303 title_template = ?, twitter = ?, canonical = ?,
304 google_verification = ?, bing_verification = ?,
305 pinterest_verification = ?, yandex_verification = ?,
306 custom_css = ?, custom_head_html = ?, custom_foot_html = ?,
307 updated_at = CURRENT_TIMESTAMP
308 WHERE id = ?
309 `).run(
310 (f.title || '').slice(0, 200),
311 (f.description || '').slice(0, 500),
312 (f.tagline || '').slice(0, 200),
313 f.language || 'nl',
314 f.palette || 'sage',
315 accent,
316 themeOverride,
317 f.profile_photo || null,
318 f.profile_enabled ? 1 : 0,
319 profileLinksJson,
320 f.is_public ? 1 : 0,
321 f.robots_index ? 1 : 0,
322 f.require_login_to_comment ? 1 : 0,
323 f.enable_audio_player ? 1 : 0,
324 f.enable_prutter ? 1 : 0,
325 moderationMode,
326 feedViewDef,
327 f.feed_view_switch ? 1 : 0,
328 f.show_search ? 1 : 0,
329 f.show_archive_link ? 1 : 0,
330 (f.title_template || '{title} — {site}').slice(0, 200),
331 (f.twitter || '').slice(0, 64) || null,
332 (f.canonical || '').slice(0, 200) || null,
333 (f.google_verification || '').slice(0, 200) || null,
334 (f.bing_verification || '').slice(0, 200) || null,
335 (f.pinterest_verification || '').slice(0, 200) || null,
336 (f.yandex_verification || '').slice(0, 200) || null,
337 f.custom_css || null,
338 f.custom_head_html || null,
339 f.custom_foot_html || null,
340 site.id,
341 );
342
343 // Owner (her)toewijzen — ALLEEN god. Een site-owner die z'n eigen site bewerkt
344 // kan de eigenaar niet wijzigen (het veld wordt voor niet-god ook niet getoond).
345 if (req.session.user.role === 'god') {
346 const newOwner = validOwnerId(req.body.owner_id);
347 if (newOwner) {
348 db.prepare('UPDATE sites SET owner_id = ? WHERE id = ?').run(newOwner, site.id);
349 grantSiteAdmin(site.id, newOwner);
350 }
351 }
352
353 res.redirect(`/admin/sites/${req.params.slug}/edit?success=` + encodeURIComponent('Opgeslagen'));
354});
355
356// ==================== MAAK PRIMAIR ====================
357// God kiest welke site de primaire/hoofd-site is (de label-/bedrijfssite in hub;
358// in solo dé site). Precies één site is primair → eerst alles uit, dan deze aan.
359router.post('/:slug/make-primary', requireGod, (req, res) => {
360 const site = db.prepare('SELECT id FROM sites WHERE slug = ?').get(req.params.slug);
361 if (!site) return res.redirect('/admin/sites?error=Niet+gevonden');
362 db.transaction(() => {
363 db.prepare('UPDATE sites SET is_primary = 0').run();
364 db.prepare('UPDATE sites SET is_primary = 1 WHERE id = ?').run(site.id);
365 })();
366 res.redirect('/admin/sites?success=' + encodeURIComponent('Primaire site bijgewerkt'));
367});
368
369// ==================== DELETE ====================
370router.post('/:slug/delete', requireGod, (req, res) => {
371 const site = db.prepare('SELECT id FROM sites WHERE slug = ?').get(req.params.slug);
372 if (!site) return res.redirect('/admin/sites?error=Not+found');
373
374 const postCount = db.prepare('SELECT COUNT(*) AS c FROM posts WHERE site_id = ?').get(site.id).c;
375 if (postCount > 0) {
376 return res.redirect('/admin/sites?error=' + encodeURIComponent(`Cannot delete: site has ${postCount} post(s). Delete posts first.`));
377 }
378
379 // Clean up site_members and audio_tracks (no posts to worry about).
380 db.prepare('DELETE FROM site_members WHERE site_id = ?').run(site.id);
381 db.prepare('DELETE FROM audio_tracks WHERE site_id = ?').run(site.id);
382 db.prepare('DELETE FROM sites WHERE id = ?').run(site.id);
383
384 res.redirect('/admin/sites?success=' + encodeURIComponent('Site deleted'));
385});
386
387export default router;
Note: See TracBrowser for help on using the repository browser.