source: Klonkt/src/middleware/render.js@ ce16d8a

main
Last change on this file since ce16d8a was 07de464, checked in by Robin Genis <roboburr@…>, 2 months ago

fix(csp): global frame-src (https:) for embeds, locked to 'self' on authorize_interaction

  • server.js — Helmet frameSrc → 'self' https: so embeds work in every context (feed, htmx/PWA, public pages); Robin chose global over per-domain.
  • middleware/render.js — renderPage now LOCKS frame-src down to 'self' on pages/authorize-interaction (untrusted remote content next to the interact buttons → no embeds/clickjacking); removed the now-unused per-domain embedOriginsFor helper.
  • Property mode set to 100644
File size: 12.0 KB
Line 
1/**
2 * Render helper — THE pattern for the entire app.
3 *
4 * Two modes:
5 * 1. HTMX request → render just the page content (no shell)
6 * 2. Full page request → render content, then embed in shell
7 *
8 * Usage:
9 * renderPage(req, res, 'pages/home', { posts, ...data })
10 */
11
12import fs from 'fs';
13import path from 'path';
14import { fileURLToPath } from 'url';
15import ejs from 'ejs';
16import db from '../config/database.js';
17import PermissionsService from '../services/PermissionsService.js';
18import { isViewer } from './auth.js';
19import { getSetting, apEnabled } from '../services/SettingsService.js';
20import { isPremium as isPremiumInstance, premiumEnabled, premiumUnlocked } from '../services/PatreonService.js';
21import ActivityPubService from '../services/ActivityPubService.js';
22import { audioEnabled as audioFeatureEnabled } from '../config/features.js';
23import { PLATFORMS as PLATFORMS_CATALOG } from '../services/PlatformIcons.js';
24import { t as i18nT, resolveLang, SUPPORTED as LANGS, LANG_NAMES } from '../services/i18n.js';
25
26const __dirname = path.dirname(fileURLToPath(import.meta.url));
27const VIEWS_DIR = path.join(__dirname, '..', 'views');
28
29// App version (from package.json) + short commit hash (from .klonkt-version, written by
30// the deploy script) — shown in the footer next to "Klonkt Beta". The hash is updated
31// automatically on every deploy, so the displayed version is never stale.
32let APP_VERSION = '';
33try {
34 APP_VERSION = JSON.parse(fs.readFileSync(path.join(__dirname, '..', '..', 'package.json'), 'utf8')).version || '';
35 try {
36 const sha = fs.readFileSync(path.join(__dirname, '..', '..', '.klonkt-version'), 'utf8').trim().slice(0, 7);
37 if (sha) APP_VERSION += ' · ' + sha;
38 } catch { /* no .klonkt-version (local dev) */ }
39} catch { /* no version available */ }
40
41// Site timezone (Admin → Settings). Empty = server default (UTC). Applied to
42// all server-side formatted dates so they display in the site's timezone instead of UTC.
43const siteTimezone = () => getSetting('timezone') || undefined;
44
45const formatDate = (iso) => {
46 if (!iso) return '';
47 return new Date(iso).toLocaleDateString('nl-NL', { timeZone: siteTimezone(), day: 'numeric', month: 'long', year: 'numeric' });
48};
49
50const formatDateTime = (iso) => {
51 if (!iso) return '';
52 return new Date(iso).toLocaleString('nl-NL', { timeZone: siteTimezone(), dateStyle: 'medium', timeStyle: 'short' });
53};
54
55export async function renderPage(req, res, viewName, data = {}) {
56 // Decide: partial (HTMX) or full?
57 const isPartial = req.headers['hx-request'] === 'true' || req.query.partial === '1';
58
59 // Prevent the browser from caching an htmx PARTIAL (only #pcms-main, without <head>/CSS)
60 // under the same URL and serving it as a full page on "back" → unstyled HTML.
61 // Vary: HX-Request separates partial and full responses in the cache;
62 // no-store on the partial forces "back" to always re-fetch the full page.
63 // (Vary also applies to intermediate caches / Cloudflare.)
64 res.setHeader('Vary', 'HX-Request');
65 if (isPartial) res.setHeader('Cache-Control', 'no-store');
66
67 // Does this (non-god) user own a site? Determines whether they see an "Admin"
68 // entry (artist self-manage). god always sees admin (by role).
69 let _u = req.session?.user || null;
70 // Refresh avatar + role from the DB so a stale session (e.g. after an
71 // avatar change or role switch) heals itself without a new login.
72 if (_u && _u.id) {
73 const _fresh = db.prepare('SELECT avatar_url, role, lang FROM users WHERE id = ?').get(_u.id);
74 if (_fresh) _u = { ..._u, avatar_url: _fresh.avatar_url, role: _fresh.role, lang: _fresh.lang };
75 // One identity: no own account avatar → fall back to the user's site photo,
76 // so the same picture shows everywhere (nav, account, comments).
77 if (_u && !_u.avatar_url) {
78 const _sp = db.prepare("SELECT profile_photo FROM sites WHERE owner_id = ? AND profile_photo IS NOT NULL ORDER BY is_primary DESC, created_at ASC LIMIT 1").get(_u.id);
79 if (_sp && _sp.profile_photo) _u = { ..._u, avatar_url: _sp.profile_photo };
80 }
81 }
82 const userOwnsSite = !!(_u && _u.role !== 'god' &&
83 db.prepare('SELECT 1 FROM sites WHERE owner_id = ? LIMIT 1').get(_u.id));
84
85 // The avatar of the SITE OWNER (not the viewer!) — for the Klonkt site header,
86 // so the artist can use their own account photo as the site photo.
87 const _site = data.site || res.locals.site || null;
88 const siteOwnerAvatar = (_site && _site.owner_id)
89 ? (db.prepare('SELECT avatar_url FROM users WHERE id = ?').get(_site.owner_id)?.avatar_url || null)
90 : null;
91
92 // Viewer mode: may view everything, change nothing. Views use canMutate
93 // to hide/disable write buttons (post, save, delete).
94 const _isViewer = isViewer(_u);
95
96 // Embeds are framed broadly (frame-src https: globally), EXCEPT on authorize_interaction:
97 // that page renders untrusted remote content next to the interact buttons, so lock its
98 // frame-src down to 'self' (no embeds → no clickjacking/overlay over the buttons).
99 if (viewName === 'pages/authorize-interaction') {
100 try {
101 const csp = res.getHeader('Content-Security-Policy');
102 if (csp) res.setHeader('Content-Security-Policy', String(csp).replace(/frame-src [^;]*/i, "frame-src 'self'"));
103 } catch { /* best-effort */ }
104 }
105
106 // Who sees the "Admin" link? god/admin, a site owner (artist self-manage),
107 // and a viewer (may view Admin read-only). One source of truth,
108 // mirrored in topnav/hub-nav/profile sheet — otherwise the link gets hidden
109 // for those who should see it (viewer didn't see it anywhere before).
110 const _role = _u ? _u.role : null;
111 const canSeeBeheer = !!(_u && (_role === 'god' || _role === 'admin' || _role === 'kijker' || userOwnsSite));
112 // Who may use the fediverse client (timeline/notifications/blocking) — actual
113 // site managers only (these routes are requireSiteManager; viewers are excluded).
114 const canManageFedi = !!(_u && (_role === 'god' || _role === 'admin' || userOwnsSite));
115
116 // Interface language: session choice (this session) → logged-in user's own preference
117 // (users.lang) → admin-set default (Admin → Settings) → env → browser → nl.
118 const _lang = resolveLang(req, {
119 userLang: _u && _u.lang,
120 defaultLang: getSetting('default_lang'),
121 });
122
123 // Common locals
124 const locals = {
125 user: _u,
126 lang: _lang,
127 t: (key, vars) => i18nT(_lang, key, vars),
128 langs: LANGS.map((c) => ({ code: c, name: LANG_NAMES[c], active: c === _lang })),
129 timezone: getSetting('timezone') || '',
130 notifUnread: (canManageFedi && _site) ? ActivityPubService.countUnseenNotifications(_site.slug) : 0,
131 userOwnsSite,
132 canSeeBeheer,
133 canManageFedi,
134 apEnabled: apEnabled(),
135 // Cirkel = the artists you feature (auto-boost). Shown when AP is on and you
136 // auto-boost ≥1 account, or (legacy) on a circle-tenancy site.
137 hasCirkel: !!(_site && apEnabled() && (ActivityPubService.autoBoostCount(_site.slug) > 0 || ActivityPubService.boostedCount(_site.slug) > 0)),
138 isViewer: _isViewer,
139 canMutate: !_isViewer,
140 isPremium: isPremiumInstance(),
141 premiumEnabled: premiumEnabled(),
142 premiumUnlocked: premiumUnlocked(),
143 siteOwnerAvatar,
144 site: _site,
145 audioEnabled: audioFeatureEnabled(),
146 audioTracks: data.audioTracks || res.locals.audioTracks || [],
147 siteUrlBase: res.locals.siteUrlBase || '',
148 tenancy: res.locals.tenancy || 'solo',
149 hubTitle: getSetting('hub_title') || '',
150 footerNewsletter: getSetting('footer_newsletter') === '1', // newsletter sign-up in footer (premium)
151 agendaEnabled: getSetting('agenda_enabled') === '1', // show agenda/events in the pill (premium, opt-in)
152 platforms_catalog: PLATFORMS_CATALOG,
153 permissions: PermissionsService,
154 formatDate,
155 formatDateTime,
156 pageTitle: data.pageTitle || (data.site && data.site.title) || 'Klonkt Beta',
157 appVersion: APP_VERSION,
158 bodyClass: data.bodyClass || 'on-home',
159 socialDescr: data.socialDescr || '',
160 socialImage: data.socialImage || '',
161 cspNonce: () => '',
162 currentPath: req.path,
163 // Absolute origin (for building absolute URLs like the generated og:image).
164 ogOrigin: (process.env.PUBLIC_BASE_URL || `${req.protocol}://${req.get('host') || ''}`).replace(/\/+$/, ''),
165 ...data,
166 };
167
168 try {
169 // Step 1: Render the page view to HTML
170 const viewPath = path.join(VIEWS_DIR, viewName + '.ejs');
171 const pageContent = await ejs.renderFile(viewPath, locals, { async: false });
172
173 if (isPartial) {
174 // HTMX: just send the content. Set HX-Trigger for body class swap.
175 // HTTP-header values are Latin-1 only — a title with an em-dash, smart
176 // quote or emoji (e.g. "Welkom — gebouwd met Klonkt") would make
177 // setHeader throw ERR_INVALID_CHAR and 500 the partial, so the card
178 // looks "unclickable". Escape any non-ASCII to \uXXXX: the header stays
179 // ASCII-safe and remains valid JSON that htmx parses back unchanged.
180 // Per-site accent + palette live in the shell <head> (style#pcms-site-accent
181 // + html[data-palette]) and are NOT swapped during htmx navigation. Send them along
182 // so the client updates them — otherwise an artist inherits the previous page's
183 // colours (e.g. hub-purple instead of their own green). Same derivation as shell.ejs.
184 const _navAccent = (_site && _site.accent && /^#[0-9a-fA-F]{6}$/.test(_site.accent))
185 ? _site.accent : '#e8b04b';
186 const _navPalette = (_site && _site.palette) ? _site.palette : 'klonkt';
187 const triggerJson = JSON.stringify({
188 pcmsNav: { bodyClass: locals.bodyClass, accent: _navAccent, palette: _navPalette },
189 pcmsPostSwap: data.post ? {
190 title: data.post.title,
191 slug: data.post.slug,
192 pageTitle: locals.pageTitle,
193 } : null,
194 }).replace(/[€-￿]/g, (ch) => '\\u' + ch.charCodeAt(0).toString(16).padStart(4, '0'));
195 res.setHeader('HX-Trigger-After-Settle', triggerJson);
196 // Render the site chrome out-of-band so the header (topnav/profile header/
197 // view-switcher) ALWAYS matches the new page/artist on navigation —
198 // while the audio player (separate in document.body) keeps playing (no
199 // interruption). htmx replaces #pcms-chrome via hx-swap-oob. Non-critical:
200 // if it fails, the old chrome remains (no crash).
201 let oobChrome = '';
202 try {
203 oobChrome = await ejs.renderFile(
204 path.join(VIEWS_DIR, 'partials', 'chrome.ejs'),
205 { ...locals, oob: true },
206 { async: false },
207 );
208 } catch (e) { /* skip chrome OOB */ }
209 return res.send(pageContent + oobChrome);
210 }
211
212 // Full: wrap content in shell
213 locals.pageContent = pageContent;
214 res.render('shell', locals);
215 } catch (err) {
216 console.error('[renderPage] Error rendering', viewName, err);
217 if (process.env.NODE_ENV === 'production') {
218 return res.status(500).send('Internal Server Error');
219 }
220 // Dev: surface the underlying cause prominently. EJS rewrites err.message
221 // to include the file/line/code-context, so we also surface name+stack
222 // separately in case the message was truncated or empty.
223 const escape = (s) => String(s == null ? '' : s)
224 .replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
225 res.status(500).send(`<!doctype html>
226<meta charset="utf-8">
227<title>Render error: ${escape(viewName)}</title>
228<style>
229 body { font: 14px/1.5 ui-monospace, monospace; max-width: 1100px; margin: 2rem auto; padding: 0 1rem; background:#1a1a1a; color:#eee; }
230 h1 { color:#dc2626; font-family: ui-sans-serif, system-ui; }
231 h2 { color:#fb923c; font-size:1rem; margin-top:1.5rem; }
232 pre { background:#0a0a0a; border:1px solid #333; border-radius:6px; padding:1rem; overflow:auto; white-space:pre-wrap; word-break:break-word; }
233 .cause { background:#3d0a0a; border-color:#7a1a1a; color:#fca5a5; font-weight:600; }
234</style>
235<h1>Render error in ${escape(viewName)}</h1>
236<h2>Cause</h2>
237<pre class="cause">${escape(err.name || 'Error')}: ${escape(err.message || '(no message)')}</pre>
238<h2>Stack</h2>
239<pre>${escape(err.stack || '(no stack)')}</pre>
240${err.path ? `<h2>File</h2><pre>${escape(err.path)}</pre>` : ''}
241`);
242 }
243}
Note: See TracBrowser for help on using the repository browser.