source: Klonkt/src/middleware/render.js@ 00d54bc

main
Last change on this file since 00d54bc was 00d54bc, checked in by roboburr <roboburr@…>, 3 months ago

Fix: htmx-partial 500 on non-ASCII characters in post title

The HX-Trigger-After-Settle header received the post title unfiltered via
JSON.stringify. HTTP header values are Latin-1; an em-dash, smart quote,
or emoji in the title (e.g. "Welkom — gebouwd met Klonkt") caused setHeader
to throw ERR_INVALID_CHAR -> partial 500 -> the card appeared "not clickable"
(full page worked fine, as it doesn't set the header).

Escape non-ASCII to \uXXXX: the header stays ASCII-safe and valid JSON that
htmx reads back unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@…>

  • Property mode set to 100644
File size: 6.1 KB
Line 
1/**
2 * Render helper — THE pattern for the entire app.
3 *
4 * Two modes:
5 * 1. HTMX request → render just the page content (no shell)
6 * 2. Full page request → render content, then embed in shell
7 *
8 * Usage:
9 * renderPage(req, res, 'pages/home', { posts, ...data })
10 */
11
12import path from 'path';
13import { fileURLToPath } from 'url';
14import ejs from 'ejs';
15import db from '../config/database.js';
16import PermissionsService from '../services/PermissionsService.js';
17import { isViewer } from './auth.js';
18import { getSetting } from '../services/SettingsService.js';
19import { PLATFORMS as PLATFORMS_CATALOG } from '../services/PlatformIcons.js';
20
21const __dirname = path.dirname(fileURLToPath(import.meta.url));
22const VIEWS_DIR = path.join(__dirname, '..', 'views');
23
24const formatDate = (iso) => {
25 if (!iso) return '';
26 const d = new Date(iso);
27 const months = ['januari','februari','maart','april','mei','juni','juli','augustus','september','oktober','november','december'];
28 return `${d.getDate()} ${months[d.getMonth()]} ${d.getFullYear()}`;
29};
30
31const formatDateTime = (iso) => {
32 if (!iso) return '';
33 const d = new Date(iso);
34 return d.toLocaleString('nl-NL', { dateStyle: 'medium', timeStyle: 'short' });
35};
36
37export async function renderPage(req, res, viewName, data = {}) {
38 // Decide: partial (HTMX) or full?
39 const isPartial = req.headers['hx-request'] === 'true' || req.query.partial === '1';
40
41 // Bezit deze (niet-god) user een eigen site? Bepaalt of 'ie een "Beheer"-
42 // ingang ziet (artiest-zelfbeheer). god ziet beheer sowieso (op rol).
43 const _u = req.session?.user || null;
44 const userOwnsSite = !!(_u && _u.role !== 'god' &&
45 db.prepare('SELECT 1 FROM sites WHERE owner_id = ? LIMIT 1').get(_u.id));
46
47 // De avatar van de SITE-EIGENAAR (niet de kijker!) — voor de Klonkt-site-kop,
48 // zodat de artiest z'n eigen account-foto als sitefoto kan gebruiken.
49 const _site = data.site || res.locals.site || null;
50 const siteOwnerAvatar = (_site && _site.owner_id)
51 ? (db.prepare('SELECT avatar_url FROM users WHERE id = ?').get(_site.owner_id)?.avatar_url || null)
52 : null;
53
54 // Kijker-modus: alles bekijken mag, niets wijzigen. Views gebruiken canMutate
55 // om schrijf-knoppen (posten, opslaan, verwijderen) te verbergen/uit te zetten.
56 const _isViewer = isViewer(_u);
57
58 // Wie ziet de "Beheer"-link? god/admin, een site-eigenaar (artiest-zelfbeheer),
59 // én een kijker (mag het Beheer alleen-lezen inzien). Eén bron van waarheid,
60 // gespiegeld in topnav/hub-nav/profielsheet — anders raakt de link verborgen
61 // voor wie 'm wél mag zien (kijker zag 'm eerst nergens).
62 const _role = _u ? _u.role : null;
63 const canSeeBeheer = !!(_u && (_role === 'god' || _role === 'admin' || _role === 'kijker' || userOwnsSite));
64
65 // Common locals
66 const locals = {
67 user: _u,
68 userOwnsSite,
69 canSeeBeheer,
70 isViewer: _isViewer,
71 canMutate: !_isViewer,
72 siteOwnerAvatar,
73 site: _site,
74 audioTracks: data.audioTracks || res.locals.audioTracks || [],
75 siteUrlBase: res.locals.siteUrlBase || '',
76 tenancy: res.locals.tenancy || 'solo',
77 hubTitle: getSetting('hub_title') || '',
78 platforms_catalog: PLATFORMS_CATALOG,
79 permissions: PermissionsService,
80 formatDate,
81 formatDateTime,
82 pageTitle: data.pageTitle || (data.site && data.site.title) || 'Klonkt Hub Beta',
83 bodyClass: data.bodyClass || 'on-home',
84 socialDescr: data.socialDescr || '',
85 socialImage: data.socialImage || '',
86 cspNonce: () => '',
87 currentPath: req.path,
88 ...data,
89 };
90
91 try {
92 // Step 1: Render the page view to HTML
93 const viewPath = path.join(VIEWS_DIR, viewName + '.ejs');
94 const pageContent = await ejs.renderFile(viewPath, locals, { async: false });
95
96 if (isPartial) {
97 // HTMX: just send the content. Set HX-Trigger for body class swap.
98 // HTTP-header values are Latin-1 only — a title with an em-dash, smart
99 // quote or emoji (e.g. "Welkom — gebouwd met Klonkt") would make
100 // setHeader throw ERR_INVALID_CHAR and 500 the partial, so the card
101 // looks "unclickable". Escape any non-ASCII to \uXXXX: the header stays
102 // ASCII-safe and remains valid JSON that htmx parses back unchanged.
103 const triggerJson = JSON.stringify({
104 pcmsNav: { bodyClass: locals.bodyClass },
105 pcmsPostSwap: data.post ? {
106 title: data.post.title,
107 slug: data.post.slug,
108 pageTitle: locals.pageTitle,
109 } : null,
110 }).replace(/[€-￿]/g, (ch) => '\\u' + ch.charCodeAt(0).toString(16).padStart(4, '0'));
111 res.setHeader('HX-Trigger-After-Settle', triggerJson);
112 return res.send(pageContent);
113 }
114
115 // Full: wrap content in shell
116 locals.pageContent = pageContent;
117 res.render('shell', locals);
118 } catch (err) {
119 console.error('[renderPage] Error rendering', viewName, err);
120 if (process.env.NODE_ENV === 'production') {
121 return res.status(500).send('Internal Server Error');
122 }
123 // Dev: surface the underlying cause prominently. EJS rewrites err.message
124 // to include the file/line/code-context, so we also surface name+stack
125 // separately in case the message was truncated or empty.
126 const escape = (s) => String(s == null ? '' : s)
127 .replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
128 res.status(500).send(`<!doctype html>
129<meta charset="utf-8">
130<title>Render error: ${escape(viewName)}</title>
131<style>
132 body { font: 14px/1.5 ui-monospace, monospace; max-width: 1100px; margin: 2rem auto; padding: 0 1rem; background:#1a1a1a; color:#eee; }
133 h1 { color:#dc2626; font-family: ui-sans-serif, system-ui; }
134 h2 { color:#fb923c; font-size:1rem; margin-top:1.5rem; }
135 pre { background:#0a0a0a; border:1px solid #333; border-radius:6px; padding:1rem; overflow:auto; white-space:pre-wrap; word-break:break-word; }
136 .cause { background:#3d0a0a; border-color:#7a1a1a; color:#fca5a5; font-weight:600; }
137</style>
138<h1>Render error in ${escape(viewName)}</h1>
139<h2>Cause</h2>
140<pre class="cause">${escape(err.name || 'Error')}: ${escape(err.message || '(no message)')}</pre>
141<h2>Stack</h2>
142<pre>${escape(err.stack || '(no stack)')}</pre>
143${err.path ? `<h2>File</h2><pre>${escape(err.path)}</pre>` : ''}
144`);
145 }
146}
Note: See TracBrowser for help on using the repository browser.