source: Klonkt/src/middleware/render.js@ 73b41eb

main
Last change on this file since 73b41eb was 1ee967d, checked in by roboburr <roboburr@…>, 3 months ago

fix(render): refresh viewer avatar + role from DB (stale session self-heal)

The topnav avatar (and role-dependent UI) came from the session blob, which
is captured on login. After the WebP migration an existing session still
pointed to the old .png → broken avatar until re-login. renderPage now reads
avatar_url + role fresh from the DB per render (one indexed lookup), so
avatar/role changes take effect immediately without re-login.

Co-Authored-By: Claude <noreply@…>

  • Property mode set to 100644
File size: 8.3 KB
Line 
1/**
2 * Render helper — THE pattern for the entire app.
3 *
4 * Two modes:
5 * 1. HTMX request → render just the page content (no shell)
6 * 2. Full page request → render content, then embed in shell
7 *
8 * Usage:
9 * renderPage(req, res, 'pages/home', { posts, ...data })
10 */
11
12import fs from 'fs';
13import path from 'path';
14import { fileURLToPath } from 'url';
15import ejs from 'ejs';
16import db from '../config/database.js';
17import PermissionsService from '../services/PermissionsService.js';
18import { isViewer } from './auth.js';
19import { getSetting } from '../services/SettingsService.js';
20import { isPremium as isPremiumInstance, premiumEnabled, premiumUnlocked } from '../services/PatreonService.js';
21import { PLATFORMS as PLATFORMS_CATALOG } from '../services/PlatformIcons.js';
22
23const __dirname = path.dirname(fileURLToPath(import.meta.url));
24const VIEWS_DIR = path.join(__dirname, '..', 'views');
25
26// App-versie (uit package.json) — getoond in de footer naast "Klonkt Beta".
27let APP_VERSION = '';
28try {
29 APP_VERSION = JSON.parse(fs.readFileSync(path.join(__dirname, '..', '..', 'package.json'), 'utf8')).version || '';
30} catch { /* geen versie beschikbaar */ }
31
32const formatDate = (iso) => {
33 if (!iso) return '';
34 const d = new Date(iso);
35 const months = ['januari','februari','maart','april','mei','juni','juli','augustus','september','oktober','november','december'];
36 return `${d.getDate()} ${months[d.getMonth()]} ${d.getFullYear()}`;
37};
38
39const formatDateTime = (iso) => {
40 if (!iso) return '';
41 const d = new Date(iso);
42 return d.toLocaleString('nl-NL', { dateStyle: 'medium', timeStyle: 'short' });
43};
44
45export async function renderPage(req, res, viewName, data = {}) {
46 // Decide: partial (HTMX) or full?
47 const isPartial = req.headers['hx-request'] === 'true' || req.query.partial === '1';
48
49 // Bezit deze (niet-god) user een eigen site? Bepaalt of 'ie een "Beheer"-
50 // ingang ziet (artiest-zelfbeheer). god ziet beheer sowieso (op rol).
51 let _u = req.session?.user || null;
52 // Ververs avatar + rol uit de DB zodat een stale sessie (bv. na een
53 // avatar-wijziging of rolwissel) zichzelf herstelt zonder opnieuw inloggen.
54 if (_u && _u.id) {
55 const _fresh = db.prepare('SELECT avatar_url, role FROM users WHERE id = ?').get(_u.id);
56 if (_fresh) _u = { ..._u, avatar_url: _fresh.avatar_url, role: _fresh.role };
57 }
58 const userOwnsSite = !!(_u && _u.role !== 'god' &&
59 db.prepare('SELECT 1 FROM sites WHERE owner_id = ? LIMIT 1').get(_u.id));
60
61 // De avatar van de SITE-EIGENAAR (niet de kijker!) — voor de Klonkt-site-kop,
62 // zodat de artiest z'n eigen account-foto als sitefoto kan gebruiken.
63 const _site = data.site || res.locals.site || null;
64 const siteOwnerAvatar = (_site && _site.owner_id)
65 ? (db.prepare('SELECT avatar_url FROM users WHERE id = ?').get(_site.owner_id)?.avatar_url || null)
66 : null;
67
68 // Kijker-modus: alles bekijken mag, niets wijzigen. Views gebruiken canMutate
69 // om schrijf-knoppen (posten, opslaan, verwijderen) te verbergen/uit te zetten.
70 const _isViewer = isViewer(_u);
71
72 // Wie ziet de "Beheer"-link? god/admin, een site-eigenaar (artiest-zelfbeheer),
73 // én een kijker (mag het Beheer alleen-lezen inzien). Eén bron van waarheid,
74 // gespiegeld in topnav/hub-nav/profielsheet — anders raakt de link verborgen
75 // voor wie 'm wél mag zien (kijker zag 'm eerst nergens).
76 const _role = _u ? _u.role : null;
77 const canSeeBeheer = !!(_u && (_role === 'god' || _role === 'admin' || _role === 'kijker' || userOwnsSite));
78
79 // Common locals
80 const locals = {
81 user: _u,
82 userOwnsSite,
83 canSeeBeheer,
84 isViewer: _isViewer,
85 canMutate: !_isViewer,
86 isPremium: isPremiumInstance(),
87 premiumEnabled: premiumEnabled(),
88 premiumUnlocked: premiumUnlocked(),
89 siteOwnerAvatar,
90 site: _site,
91 audioTracks: data.audioTracks || res.locals.audioTracks || [],
92 siteUrlBase: res.locals.siteUrlBase || '',
93 tenancy: res.locals.tenancy || 'solo',
94 hubTitle: getSetting('hub_title') || '',
95 footerNewsletter: getSetting('footer_newsletter') === '1', // nieuwsbrief-aanmelding in footer (premium)
96 platforms_catalog: PLATFORMS_CATALOG,
97 permissions: PermissionsService,
98 formatDate,
99 formatDateTime,
100 pageTitle: data.pageTitle || (data.site && data.site.title) || 'Klonkt Beta',
101 appVersion: APP_VERSION,
102 bodyClass: data.bodyClass || 'on-home',
103 socialDescr: data.socialDescr || '',
104 socialImage: data.socialImage || '',
105 cspNonce: () => '',
106 currentPath: req.path,
107 ...data,
108 };
109
110 try {
111 // Step 1: Render the page view to HTML
112 const viewPath = path.join(VIEWS_DIR, viewName + '.ejs');
113 const pageContent = await ejs.renderFile(viewPath, locals, { async: false });
114
115 if (isPartial) {
116 // HTMX: just send the content. Set HX-Trigger for body class swap.
117 // HTTP-header values are Latin-1 only — a title with an em-dash, smart
118 // quote or emoji (e.g. "Welkom — gebouwd met Klonkt") would make
119 // setHeader throw ERR_INVALID_CHAR and 500 the partial, so the card
120 // looks "unclickable". Escape any non-ASCII to \uXXXX: the header stays
121 // ASCII-safe and remains valid JSON that htmx parses back unchanged.
122 // Per-site accent + palette zitten in de shell-<head> (style#pcms-site-accent
123 // + html[data-palette]) en worden NIET mee-geswapt bij htmx-nav. Stuur ze mee
124 // zodat de client ze bijwerkt — anders erft een artiest de kleuren van de
125 // vorige pagina (bv. hub-paars i.p.v. eigen groen). Zelfde afleiding als shell.ejs.
126 const _navAccent = (_site && _site.accent && /^#[0-9a-fA-F]{6}$/.test(_site.accent))
127 ? _site.accent : '#c2410c';
128 const _navPalette = (_site && _site.palette) ? _site.palette : 'sage';
129 const triggerJson = JSON.stringify({
130 pcmsNav: { bodyClass: locals.bodyClass, accent: _navAccent, palette: _navPalette },
131 pcmsPostSwap: data.post ? {
132 title: data.post.title,
133 slug: data.post.slug,
134 pageTitle: locals.pageTitle,
135 } : null,
136 }).replace(/[€-￿]/g, (ch) => '\\u' + ch.charCodeAt(0).toString(16).padStart(4, '0'));
137 res.setHeader('HX-Trigger-After-Settle', triggerJson);
138 // Site-chrome out-of-band mee-renderen, zodat de kop (topnav/profielkop/
139 // view-switcher) bij navigatie ALTIJD bij de nieuwe pagina/artiest hoort —
140 // terwijl de audioplayer (los in document.body) blijft leven (geen
141 // verspringen). htmx vervangt #pcms-chrome via hx-swap-oob. Niet kritisch:
142 // faalt 't, dan blijft de oude chrome staan (geen crash).
143 let oobChrome = '';
144 try {
145 oobChrome = await ejs.renderFile(
146 path.join(VIEWS_DIR, 'partials', 'chrome.ejs'),
147 { ...locals, oob: true },
148 { async: false },
149 );
150 } catch (e) { /* chrome-OOB overslaan */ }
151 return res.send(pageContent + oobChrome);
152 }
153
154 // Full: wrap content in shell
155 locals.pageContent = pageContent;
156 res.render('shell', locals);
157 } catch (err) {
158 console.error('[renderPage] Error rendering', viewName, err);
159 if (process.env.NODE_ENV === 'production') {
160 return res.status(500).send('Internal Server Error');
161 }
162 // Dev: surface the underlying cause prominently. EJS rewrites err.message
163 // to include the file/line/code-context, so we also surface name+stack
164 // separately in case the message was truncated or empty.
165 const escape = (s) => String(s == null ? '' : s)
166 .replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
167 res.status(500).send(`<!doctype html>
168<meta charset="utf-8">
169<title>Render error: ${escape(viewName)}</title>
170<style>
171 body { font: 14px/1.5 ui-monospace, monospace; max-width: 1100px; margin: 2rem auto; padding: 0 1rem; background:#1a1a1a; color:#eee; }
172 h1 { color:#dc2626; font-family: ui-sans-serif, system-ui; }
173 h2 { color:#fb923c; font-size:1rem; margin-top:1.5rem; }
174 pre { background:#0a0a0a; border:1px solid #333; border-radius:6px; padding:1rem; overflow:auto; white-space:pre-wrap; word-break:break-word; }
175 .cause { background:#3d0a0a; border-color:#7a1a1a; color:#fca5a5; font-weight:600; }
176</style>
177<h1>Render error in ${escape(viewName)}</h1>
178<h2>Cause</h2>
179<pre class="cause">${escape(err.name || 'Error')}: ${escape(err.message || '(no message)')}</pre>
180<h2>Stack</h2>
181<pre>${escape(err.stack || '(no stack)')}</pre>
182${err.path ? `<h2>File</h2><pre>${escape(err.path)}</pre>` : ''}
183`);
184 }
185}
Note: See TracBrowser for help on using the repository browser.